replace nulls with empty string in template#63
Merged
CloudUki merged 1 commit intomirrulations:mainfrom Apr 22, 2025
Merged
Conversation
Contributor
|
Does it display and error for this if the values are null? Should I document this down as well in the README incase? |
Author
|
@CloudUki The SAM Validate command does not detect if the values are null, apparently. It might be something worth documenting briefly, but I am not expecting anyone to add null values to the template typically, as they were only added to run locally for some situations. I am creating an issue for this on the AWS SAM CLI repo because it should realistically be failing the sam validate, but who knows how long that will take to get addressed. |
Contributor
|
@ZingBing perfect thank you. I can write something brief about it and ask for you to review it and we can move on from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zach told me that even though the template passes validation it does not deploy properly with null values, this replaces them with empty strings.